2013-06-25 Paolo Carlini <paolo.carlini@oracle.com>
authorpaolo <paolo@138bc75d-0d04-0410-961f-82ee72b054a4>
Tue, 25 Jun 2013 08:39:31 +0000 (08:39 +0000)
committerpaolo <paolo@138bc75d-0d04-0410-961f-82ee72b054a4>
Tue, 25 Jun 2013 08:39:31 +0000 (08:39 +0000)
PR libstdc++/57704
* include/bits/char_traits.h (char_traits<char>::lt): Implement
LWG 467.
* testsuite/21_strings/char_traits/requirements/char/57704.cc: New.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@200392 138bc75d-0d04-0410-961f-82ee72b054a4

libstdc++-v3/ChangeLog
libstdc++-v3/include/bits/char_traits.h
libstdc++-v3/testsuite/21_strings/char_traits/requirements/char/57704.cc [new file with mode: 0644]

index 27142f3..b7a10c1 100644 (file)
@@ -1,3 +1,10 @@
+2013-06-25  Paolo Carlini  <paolo.carlini@oracle.com>
+
+       PR libstdc++/57704
+       * include/bits/char_traits.h (char_traits<char>::lt): Implement
+       LWG 467.
+       * testsuite/21_strings/char_traits/requirements/char/57704.cc: New.
+
 2013-06-24  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 
        PR libstdc++/57691
index c293495..0d0f7cc 100644 (file)
@@ -248,7 +248,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 
       static _GLIBCXX_CONSTEXPR bool
       lt(const char_type& __c1, const char_type& __c2) _GLIBCXX_NOEXCEPT
-      { return __c1 < __c2; }
+      {
+       // LWG 467.
+       return (static_cast<unsigned char>(__c1)
+               < static_cast<unsigned char>(__c2));
+      }
 
       static int
       compare(const char_type* __s1, const char_type* __s2, size_t __n)
diff --git a/libstdc++-v3/testsuite/21_strings/char_traits/requirements/char/57704.cc b/libstdc++-v3/testsuite/21_strings/char_traits/requirements/char/57704.cc
new file mode 100644 (file)
index 0000000..7873d0d
--- /dev/null
@@ -0,0 +1,37 @@
+// Copyright (C) 2013 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <string>
+#include <testsuite_hooks.h>
+
+void test01()
+{
+  bool test __attribute__((unused)) = true;
+
+  char a = '\x7f';
+  char b = '\x80';
+
+  VERIFY( (std::char_traits<char>::lt(a, b)
+          == (static_cast<unsigned char>(a)
+              < static_cast<unsigned char>(b))) );
+}
+
+int main()
+{
+  test01();
+  return 0;
+}