analyzer: fix ICE due to NULL type [PR96639]
authorDavid Malcolm <dmalcolm@redhat.com>
Mon, 17 Aug 2020 15:40:44 +0000 (11:40 -0400)
committerDavid Malcolm <dmalcolm@redhat.com>
Mon, 17 Aug 2020 18:46:10 +0000 (14:46 -0400)
gcc/analyzer/ChangeLog:
PR analyzer/96639
* region.cc (region::get_subregions_for_binding): Check for "type"
being NULL.

gcc/testsuite/ChangeLog:
PR analyzer/96639
* gcc.dg/analyzer/pr96639.c: New test.

gcc/analyzer/region.cc
gcc/testsuite/gcc.dg/analyzer/pr96639.c [new file with mode: 0644]

index afe416b..eab1f27 100644 (file)
@@ -256,7 +256,7 @@ region::get_subregions_for_binding (region_model_manager *mgr,
                                    tree type,
                                    auto_vec <const region *> *out) const
 {
-  if (get_type () == NULL_TREE)
+  if (get_type () == NULL_TREE || type == NULL_TREE)
     return;
   if (relative_bit_offset == 0
       && types_compatible_p (get_type (), type))
diff --git a/gcc/testsuite/gcc.dg/analyzer/pr96639.c b/gcc/testsuite/gcc.dg/analyzer/pr96639.c
new file mode 100644 (file)
index 0000000..02ca3f0
--- /dev/null
@@ -0,0 +1,10 @@
+void *calloc (__SIZE_TYPE__, __SIZE_TYPE__);
+
+int
+x7 (void)
+{
+  int **md = calloc (1, 1);
+
+  return md[0][0]; /* { dg-warning "possibly-NULL" "unchecked deref" } */
+  /* { dg-warning "leak of 'md'" "leak" { target *-*-* } .-1 } */
+}