MIPS: make kgdb depend on FPU support
authorArnd Bergmann <arnd@arndb.de>
Fri, 22 Jan 2021 11:02:51 +0000 (12:02 +0100)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Fri, 22 Jan 2021 12:53:25 +0000 (13:53 +0100)
kgdb fails to build when the FPU support is disabled:

arch/mips/kernel/kgdb.c: In function 'dbg_set_reg':
arch/mips/kernel/kgdb.c:147:35: error: 'struct thread_struct' has no member named 'fpu'
  147 |    memcpy((void *)&current->thread.fpu.fcr31, mem,
      |                                   ^
arch/mips/kernel/kgdb.c:155:34: error: 'struct thread_struct' has no member named 'fpu'
  155 |   memcpy((void *)&current->thread.fpu.fpr[fp_reg], mem,

This is only relevant for CONFIG_EXPERT=y, so disallowing it
in Kconfig is an easier workaround than fixing it properly.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/Kconfig

index 32df972..62475fc 100644 (file)
@@ -43,7 +43,7 @@ config MIPS
        select HANDLE_DOMAIN_IRQ
        select HAVE_ARCH_COMPILER_H
        select HAVE_ARCH_JUMP_LABEL
-       select HAVE_ARCH_KGDB
+       select HAVE_ARCH_KGDB if MIPS_FP_SUPPORT
        select HAVE_ARCH_MMAP_RND_BITS if MMU
        select HAVE_ARCH_MMAP_RND_COMPAT_BITS if MMU && COMPAT
        select HAVE_ARCH_SECCOMP_FILTER