[iter] Remove passing pointer to hb_iter()

While doable with hb_deref_pointer() as well, we also would then
need to do it in a ton of places.  Not worth it / messy.

diff --git a/src/hb-array.hh b/src/hb-array.hh
index fc8d39d..4e8933f 100644 (file)
--- a/src/hb-array.hh
+++ b/src/hb-array.hh
@@ -279,7 +279,7 @@ template <typename T>
 uint32_t hb_array_t<T>::hash () const
 {
   return
-  + hb_iter (this)
+  + hb_iter (*this)
   | hb_map (hb_hash)
   | hb_reduce ([] (uint32_t a, uint32_t b) -> uint32_t { return a * 31 + b; }, 0)
   ;

diff --git a/src/hb-iter.hh b/src/hb-iter.hh
index 9a3c2f4..f23904c 100644 (file)
--- a/src/hb-iter.hh
+++ b/src/hb-iter.hh
@@ -137,11 +137,6 @@ static const struct
   operator () (T&& c) const
   { return c.iter (); }
 
-  template <typename T>
-  hb_iter_t (T)
-  operator () (T* c) const
-  { return c->iter (); }
-
   /* Specialization for C arrays. */
 
   template <typename Type> inline hb_array_t<Type>

diff --git a/src/test-iter.cc b/src/test-iter.cc
index dcfdd11..675bbe3 100644 (file)
--- a/src/test-iter.cc
+++ b/src/test-iter.cc
@@ -106,9 +106,6 @@ main (int argc, char **argv)
   int dst[20];
   hb_vector_t<int> v;
 
-  hb_iter (v);
-  hb_iter (&v);
-
   array_iter_t<const int> s (src); /* Implicit conversion from static array. */
   array_iter_t<const int> s2 (v); /* Implicit conversion from vector. */
   array_iter_t<int> t (dst);