media: staging: media: zoran: multiple assignments should be avoided
authorCorentin Labbe <clabbe@baylibre.com>
Tue, 18 May 2021 12:41:10 +0000 (14:41 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 2 Jun 2021 12:02:45 +0000 (14:02 +0200)
Remove all multiple assignments.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/zoran/zoran_driver.c
drivers/staging/media/zoran/zr36016.c
drivers/staging/media/zoran/zr36050.c
drivers/staging/media/zoran/zr36060.c

index e8902f8..46382e4 100644 (file)
@@ -678,12 +678,14 @@ static int zoran_g_selection(struct file *file, void *__fh, struct v4l2_selectio
                sel->r.height = zr->jpg_settings.img_height;
                break;
        case V4L2_SEL_TGT_CROP_DEFAULT:
-               sel->r.top = sel->r.left = 0;
+               sel->r.top = 0;
+               sel->r.left = 0;
                sel->r.width = BUZ_MIN_WIDTH;
                sel->r.height = BUZ_MIN_HEIGHT;
                break;
        case V4L2_SEL_TGT_CROP_BOUNDS:
-               sel->r.top = sel->r.left = 0;
+               sel->r.top = 0;
+               sel->r.left = 0;
                sel->r.width = BUZ_MAX_WIDTH;
                sel->r.height = BUZ_MAX_HEIGHT;
                break;
index 2d7dc7a..82702a1 100644 (file)
@@ -361,7 +361,8 @@ static int zr36016_setup(struct videocodec *codec)
                return -ENOSPC;
        }
        //mem structure init
-       codec->data = ptr = kzalloc(sizeof(struct zr36016), GFP_KERNEL);
+       ptr = kzalloc(sizeof(struct zr36016), GFP_KERNEL);
+       codec->data = ptr;
        if (!ptr)
                return -ENOMEM;
 
index 2826f4e..a788628 100644 (file)
@@ -754,7 +754,8 @@ static int zr36050_setup(struct videocodec *codec)
                return -ENOSPC;
        }
        //mem structure init
-       codec->data = ptr = kzalloc(sizeof(struct zr36050), GFP_KERNEL);
+       ptr = kzalloc(sizeof(struct zr36050), GFP_KERNEL);
+       codec->data = ptr;
        if (!ptr)
                return -ENOMEM;
 
index 4f9eb9f..1c3af11 100644 (file)
@@ -790,7 +790,8 @@ static int zr36060_setup(struct videocodec *codec)
                return -ENOSPC;
        }
        //mem structure init
-       codec->data = ptr = kzalloc(sizeof(*ptr), GFP_KERNEL);
+       ptr = kzalloc(sizeof(*ptr), GFP_KERNEL);
+       codec->data = ptr;
        if (!ptr)
                return -ENOMEM;