[M120 Migration][WRTJS] Fix JS modal popup failure 13/307713/5
authorAgnel C J Kurian <agnel.kurian@partner.samsung.com>
Tue, 12 Mar 2024 10:40:35 +0000 (16:10 +0530)
committerDae-Hyun Ko <dhyuna.ko@samsung.com>
Tue, 19 Mar 2024 07:50:21 +0000 (07:50 +0000)
In onscreen rendering mode, we send |window_| as evas to popup
instead of |view_| which tries to go higher up the hierarchy
resulting in null object. This change fixes that as per the
object received.

References:
https://review.tizen.org/gerrit/290553/

Change-Id: I03bf4d2d4554bb4b9945621d2920ed1feea3a26d
Signed-off-by: Agnel C J Kurian <agnel.kurian@partner.samsung.com>
tizen_src/chromium_impl/content/browser/javascript_dialog/javascript_modal_dialog.cc

index d1411e9..d991969 100644 (file)
@@ -59,7 +59,6 @@ JavaScriptModalDialog::JavaScriptModalDialog(
       conformant_(nullptr),
       popup_(nullptr),
       prompt_entry_(nullptr),
-      parent_(elm_object_parent_widget_get(ewk_view)),
       is_callback_processed_(false),
       is_showing_(false),
       web_contents_(web_contents),
@@ -67,7 +66,13 @@ JavaScriptModalDialog::JavaScriptModalDialog(
       message_text_(message_text),
       default_prompt_text_(default_prompt_text),
       close_callback_(std::move(callback)),
-      prompt_entry_changed_callback_(nullptr) {}
+      prompt_entry_changed_callback_(nullptr) {
+  if (elm_object_parent_widget_get(ewk_view)) {
+    parent_ = elm_object_parent_widget_get(ewk_view);
+  } else {
+    parent_ = ewk_view;
+  }
+}
 
 JavaScriptModalDialog::~JavaScriptModalDialog() {
   Close();