Don't save the key file when loading Personas' aliases

We were previously saving the key file for each __alias key loaded, as it was
loading the alias into Kf.Persona.alias, rather than Kf.Persona._alias,
causing the key file to be saved each time.

This may have caused or contributed towards the corruption seen in bgo#628930.

diff --git a/backends/key-file/kf-persona.vala b/backends/key-file/kf-persona.vala
index fed5547..bfb669d 100644 (file)
--- a/backends/key-file/kf-persona.vala
+++ b/backends/key-file/kf-persona.vala
@@ -135,7 +135,7 @@ public class Folks.Backends.Kf.Persona : Folks.Persona,
               /* Alias */
               if (key == "__alias")
                 {
-                  this.alias = this.key_file.get_string (this.display_id, key);
+                  this._alias = this.key_file.get_string (this.display_id, key);
                   continue;
                 }