selftests/bpf: Remove too strict field offset relo test cases
authorAndrii Nakryiko <andriin@fb.com>
Fri, 1 Nov 2019 22:28:06 +0000 (15:28 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 4 Nov 2019 15:06:56 +0000 (16:06 +0100)
As libbpf is going to gain support for more field relocations, including field
size, some restrictions about exact size match are going to be lifted. Remove
test cases that explicitly test such failures.

Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20191101222810.1246166-2-andriin@fb.com
tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type.c [new file with mode: 0644]
tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type1.c [deleted file]
tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type2.c [deleted file]
tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_bitfield.c [deleted file]
tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_16.c [deleted file]
tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_32.c [deleted file]
tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_64.c [deleted file]
tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_8.c [deleted file]
tools/testing/selftests/bpf/progs/core_reloc_types.h

diff --git a/tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type.c b/tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type.c
new file mode 100644 (file)
index 0000000..f5a7c83
--- /dev/null
@@ -0,0 +1,3 @@
+#include "core_reloc_types.h"
+
+void f(struct core_reloc_arrays___err_wrong_val_type x) {}
diff --git a/tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type1.c b/tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type1.c
deleted file mode 100644 (file)
index 795a5b7..0000000
+++ /dev/null
@@ -1,3 +0,0 @@
-#include "core_reloc_types.h"
-
-void f(struct core_reloc_arrays___err_wrong_val_type1 x) {}
diff --git a/tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type2.c b/tools/testing/selftests/bpf/progs/btf__core_reloc_arrays___err_wrong_val_type2.c
deleted file mode 100644 (file)
index 3af74b8..0000000
+++ /dev/null
@@ -1,3 +0,0 @@
-#include "core_reloc_types.h"
-
-void f(struct core_reloc_arrays___err_wrong_val_type2 x) {}
diff --git a/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_bitfield.c b/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_bitfield.c
deleted file mode 100644 (file)
index 50369e8..0000000
+++ /dev/null
@@ -1,3 +0,0 @@
-#include "core_reloc_types.h"
-
-void f(struct core_reloc_ints___err_bitfield x) {}
diff --git a/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_16.c b/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_16.c
deleted file mode 100644 (file)
index 823bac1..0000000
+++ /dev/null
@@ -1,3 +0,0 @@
-#include "core_reloc_types.h"
-
-void f(struct core_reloc_ints___err_wrong_sz_16 x) {}
diff --git a/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_32.c b/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_32.c
deleted file mode 100644 (file)
index b44f3be..0000000
+++ /dev/null
@@ -1,3 +0,0 @@
-#include "core_reloc_types.h"
-
-void f(struct core_reloc_ints___err_wrong_sz_32 x) {}
diff --git a/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_64.c b/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_64.c
deleted file mode 100644 (file)
index 9a3dd20..0000000
+++ /dev/null
@@ -1,3 +0,0 @@
-#include "core_reloc_types.h"
-
-void f(struct core_reloc_ints___err_wrong_sz_64 x) {}
diff --git a/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_8.c b/tools/testing/selftests/bpf/progs/btf__core_reloc_ints___err_wrong_sz_8.c
deleted file mode 100644 (file)
index 9f11ef5..0000000
+++ /dev/null
@@ -1,3 +0,0 @@
-#include "core_reloc_types.h"
-
-void f(struct core_reloc_ints___err_wrong_sz_8 x) {}
index f5939d9..3fe54f6 100644 (file)
@@ -386,14 +386,7 @@ struct core_reloc_arrays___err_non_array {
        struct core_reloc_arrays_substruct d[1][2];
 };
 
-struct core_reloc_arrays___err_wrong_val_type1 {
-       char a[5]; /* char instead of int */
-       char b[2][3][4];
-       struct core_reloc_arrays_substruct c[3];
-       struct core_reloc_arrays_substruct d[1][2];
-};
-
-struct core_reloc_arrays___err_wrong_val_type2 {
+struct core_reloc_arrays___err_wrong_val_type {
        int a[5];
        char b[2][3][4];
        int c[3]; /* value is not a struct */
@@ -589,67 +582,6 @@ struct core_reloc_ints___bool {
        int64_t         s64_field;
 };
 
-struct core_reloc_ints___err_bitfield {
-       uint8_t         u8_field;
-       int8_t          s8_field;
-       uint16_t        u16_field;
-       int16_t         s16_field;
-       uint32_t        u32_field: 32; /* bitfields are not supported */
-       int32_t         s32_field;
-       uint64_t        u64_field;
-       int64_t         s64_field;
-};
-
-struct core_reloc_ints___err_wrong_sz_8 {
-       uint16_t        u8_field; /* not 8-bit anymore */
-       int16_t         s8_field; /* not 8-bit anymore */
-
-       uint16_t        u16_field;
-       int16_t         s16_field;
-       uint32_t        u32_field;
-       int32_t         s32_field;
-       uint64_t        u64_field;
-       int64_t         s64_field;
-};
-
-struct core_reloc_ints___err_wrong_sz_16 {
-       uint8_t         u8_field;
-       int8_t          s8_field;
-
-       uint32_t        u16_field; /* not 16-bit anymore */
-       int32_t         s16_field; /* not 16-bit anymore */
-
-       uint32_t        u32_field;
-       int32_t         s32_field;
-       uint64_t        u64_field;
-       int64_t         s64_field;
-};
-
-struct core_reloc_ints___err_wrong_sz_32 {
-       uint8_t         u8_field;
-       int8_t          s8_field;
-       uint16_t        u16_field;
-       int16_t         s16_field;
-
-       uint64_t        u32_field; /* not 32-bit anymore */
-       int64_t         s32_field; /* not 32-bit anymore */
-
-       uint64_t        u64_field;
-       int64_t         s64_field;
-};
-
-struct core_reloc_ints___err_wrong_sz_64 {
-       uint8_t         u8_field;
-       int8_t          s8_field;
-       uint16_t        u16_field;
-       int16_t         s16_field;
-       uint32_t        u32_field;
-       int32_t         s32_field;
-
-       uint32_t        u64_field; /* not 64-bit anymore */
-       int32_t         s64_field; /* not 64-bit anymore */
-};
-
 /*
  * MISC
  */