powerpc/pseries/vas: Call misc_deregister if sysfs init fails

Undo effects of misc_register if sysfs init fails after
misc_register.

Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220511033507.2745992-1-zhengbin13@huawei.com

diff --git a/arch/powerpc/platforms/pseries/vas-sysfs.c b/arch/powerpc/platforms/pseries/vas-sysfs.c
index d06c0a0..f9f6827 100644 (file)
--- a/arch/powerpc/platforms/pseries/vas-sysfs.c
+++ b/arch/powerpc/platforms/pseries/vas-sysfs.c
@@ -248,6 +248,7 @@ int __init sysfs_pseries_vas_init(struct vas_all_caps *vas_caps)
        pseries_vas_kobj = kobject_create_and_add("vas0",
                                        &vas_miscdev.this_device->kobj);
        if (!pseries_vas_kobj) {
+               misc_deregister(&vas_miscdev);
                pr_err("Failed to create VAS sysfs entry\n");
                return -ENOMEM;
        }
@@ -259,6 +260,7 @@ int __init sysfs_pseries_vas_init(struct vas_all_caps *vas_caps)
                if (!gzip_caps_kobj) {
                        pr_err("Failed to create VAS GZIP capability entry\n");
                        kobject_put(pseries_vas_kobj);
+                       misc_deregister(&vas_miscdev);
                        return -ENOMEM;
                }
        }