r8169: disable detection of chip version 36
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 9 Sep 2022 06:00:22 +0000 (08:00 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 19 Sep 2022 21:10:23 +0000 (14:10 -0700)
I found no evidence that this chip version ever made it to the mass
market. Therefore disable detection. Like in similar cases before:
If nobody complains, we'll remove support for this chip version after
few months.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/ac622d4a-ae0a-3817-710f-849db4015c78@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index f6f63ba..9c21894 100644 (file)
@@ -1996,7 +1996,10 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
 
                /* 8168F family. */
                { 0x7c8, 0x488, RTL_GIGA_MAC_VER_38 },
-               { 0x7cf, 0x481, RTL_GIGA_MAC_VER_36 },
+               /* It seems this chip version never made it to
+                * the wild. Let's disable detection.
+                * { 0x7cf, 0x481,      RTL_GIGA_MAC_VER_36 },
+                */
                { 0x7cf, 0x480, RTL_GIGA_MAC_VER_35 },
 
                /* 8168E family. */