When a parameter list in a C function has an error, recover by forming a K&R function,
authorArgyrios Kyrtzidis <akyrtzi@gmail.com>
Fri, 22 Feb 2013 06:58:32 +0000 (06:58 +0000)
committerArgyrios Kyrtzidis <akyrtzi@gmail.com>
Fri, 22 Feb 2013 06:58:32 +0000 (06:58 +0000)
instead of a non-function type.

llvm-svn: 175868

clang/lib/Sema/SemaType.cpp
clang/test/Sema/alloc_size.c
clang/test/Sema/invalid-decl.c

index 209699f..c47a7f5 100644 (file)
@@ -2580,6 +2580,8 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state,
           // definition.
           S.Diag(FTI.ArgInfo[0].IdentLoc, diag::err_ident_list_in_fn_declaration);
           D.setInvalidType(true);
+          // Recover by creating a K&R-style function type.
+          T = Context.getFunctionNoProtoType(T);
           break;
         }
 
index 6a580b5..84f3932 100644 (file)
@@ -23,5 +23,5 @@ void* fn9(unsigned) __attribute__((alloc_size(12345678901234567890123))); // exp
 
 void* fn10(size_t, size_t) __attribute__((alloc_size(1,2))); // expected-error{{redefinition of parameter}} \
                                                              // expected-error{{a parameter list without types is only allowed in a function definition}} \
-                                                             // expected-warning{{alloc_size attribute only applies to functions and methods}}
+                                                             // expected-error{{attribute parameter 1 is out of bounds}}
 void* fn11() __attribute__((alloc_size(1))); // expected-error{{attribute parameter 1 is out of bounds}}
index b2c2aaf..4e62881 100644 (file)
@@ -38,3 +38,7 @@ static void bar(hid_t p, char); // expected-error {{unknown type name 'hid_t'}}
 void foo() {
   (void)bar;
 }
+
+void test2();
+void test2(undef); // expected-error {{a parameter list without types is only allowed in a function definition}}
+void test2() { }