lcs: get rid of compile warning
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Thu, 12 May 2011 18:45:05 +0000 (18:45 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 May 2011 18:55:20 +0000 (14:55 -0400)
-Wunused-but-set-variable generates a compile warning for lcs' tasklet
function. Invoked functions contain already error handling; thus
additional return code checking is not needed here.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/lcs.c

index 49d1cfc..c3b8064 100644 (file)
@@ -1483,7 +1483,6 @@ lcs_tasklet(unsigned long data)
        struct lcs_channel *channel;
        struct lcs_buffer *iob;
        int buf_idx;
-       int rc;
 
        channel = (struct lcs_channel *) data;
        LCS_DBF_TEXT_(5, trace, "tlet%s", dev_name(&channel->ccwdev->dev));
@@ -1500,14 +1499,11 @@ lcs_tasklet(unsigned long data)
        channel->buf_idx = buf_idx;
 
        if (channel->state == LCS_CH_STATE_STOPPED)
-               // FIXME: what if rc != 0 ??
-               rc = lcs_start_channel(channel);
+               lcs_start_channel(channel);
        spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags);
        if (channel->state == LCS_CH_STATE_SUSPENDED &&
-           channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY) {
-               // FIXME: what if rc != 0 ??
-               rc = __lcs_resume_channel(channel);
-       }
+           channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY)
+               __lcs_resume_channel(channel);
        spin_unlock_irqrestore(get_ccwdev_lock(channel->ccwdev), flags);
 
        /* Something happened on the channel. Wake up waiters. */