usb: xhci: plat: remove error log for failure to get usb-phy
authorStanley Chang <stanley_chang@realtek.com>
Wed, 10 May 2023 07:51:29 +0000 (15:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 May 2023 09:05:43 +0000 (18:05 +0900)
Remove this log to avoid non-error conditions.
If CONFIG_USB_PHY is disabled, the following error message appears:
[    0.231609] xhci-hcd f10f0000.usb3: xhci_plat_probe get usb3phy fail (ret=-6)
[    0.239716] xhci-hcd f10f8000.usb3: xhci_plat_probe get usb3phy fail (ret=-6)
In this case, devm_usb_get_phy_by_phandle is declared static inline
and returns -ENXIO.

It is easy to pinpoint the failure to get the usb-phy using the debug
log in drivers/usb/phy/phy.c. Therefore, it can be removed.

Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
Tested-by: Klaus Kudielka <klaus.kudielka@gmail.com>
Link: https://lore.kernel.org/r/20230510075129.28047-1-stanley_chang@realtek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-plat.c

index f36633f..a666b21 100644 (file)
@@ -294,10 +294,6 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
                xhci->shared_hcd->usb_phy = devm_usb_get_phy_by_phandle(sysdev,
                            "usb-phy", 1);
                if (IS_ERR(xhci->shared_hcd->usb_phy)) {
-                       if (PTR_ERR(xhci->shared_hcd->usb_phy) != -ENODEV)
-                               dev_err(sysdev, "%s get usb3phy fail (ret=%d)\n",
-                                            __func__,
-                                           (int)PTR_ERR(xhci->shared_hcd->usb_phy));
                        xhci->shared_hcd->usb_phy = NULL;
                } else {
                        ret = usb_phy_init(xhci->shared_hcd->usb_phy);