projects
/
platform
/
upstream
/
gstreamer.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5f027ae
)
gstutils: remove incorrect Fixme comment
author
Luis de Bethencourt
<luis.bg@samsung.com>
Wed, 25 Feb 2015 16:11:06 +0000
(16:11 +0000)
committer
Luis de Bethencourt
<luis.bg@samsung.com>
Wed, 25 Feb 2015 16:11:06 +0000
(16:11 +0000)
If the checks were changed to using g_return_if_fail() the GST_DEBUG lines
about the specific failure would be lost.
gst/gstutils.c
patch
|
blob
|
history
diff --git
a/gst/gstutils.c
b/gst/gstutils.c
index
abc7b5d
..
54b2d80
100644
(file)
--- a/
gst/gstutils.c
+++ b/
gst/gstutils.c
@@
-931,7
+931,6
@@
gst_pad_check_link (GstPad * srcpad, GstPad * sinkpad)
GST_CAT_INFO (GST_CAT_PADS, "trying to link %s:%s and %s:%s",
GST_DEBUG_PAD_NAME (srcpad), GST_DEBUG_PAD_NAME (sinkpad));
- /* FIXME: shouldn't we convert this to g_return_val_if_fail? */
if (GST_PAD_PEER (srcpad) != NULL) {
GST_CAT_INFO (GST_CAT_PADS, "Source pad %s:%s has a peer, failed",
GST_DEBUG_PAD_NAME (srcpad));