hwmon: (gsc-hwmon) fix fan pwm temperature scaling
authorTim Harvey <tharvey@gateworks.com>
Tue, 6 Jun 2023 15:30:04 +0000 (08:30 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:26 +0000 (16:21 +0200)
[ Upstream commit a6d80df47ee2c69db99e4f2f8871aa4db154620b ]

The GSC fan pwm temperature register is in centidegrees celcius but the
Linux hwmon convention is to use milidegrees celcius. Fix the scaling.

Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Link: https://lore.kernel.org/r/20230606153004.1448086-1-tharvey@gateworks.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/gsc-hwmon.c

index b60ec95b5edbf248da1d4abfd1abff494180beaa..74bfc21c2767b16ac93bf5c7633b77ee6fde68a7 100644 (file)
@@ -82,8 +82,8 @@ static ssize_t pwm_auto_point_temp_store(struct device *dev,
        if (kstrtol(buf, 10, &temp))
                return -EINVAL;
 
-       temp = clamp_val(temp, 0, 10000);
-       temp = DIV_ROUND_CLOSEST(temp, 10);
+       temp = clamp_val(temp, 0, 100000);
+       temp = DIV_ROUND_CLOSEST(temp, 100);
 
        regs[0] = temp & 0xff;
        regs[1] = (temp >> 8) & 0xff;
@@ -100,7 +100,7 @@ static ssize_t pwm_auto_point_pwm_show(struct device *dev,
 {
        struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
 
-       return sprintf(buf, "%d\n", 255 * (50 + (attr->index * 10)) / 100);
+       return sprintf(buf, "%d\n", 255 * (50 + (attr->index * 10)));
 }
 
 static SENSOR_DEVICE_ATTR_RO(pwm1_auto_point1_pwm, pwm_auto_point_pwm, 0);