powerpc/tau: Remove duplicated set_thresholds() call
authorFinn Thain <fthain@telegraphics.com.au>
Fri, 4 Sep 2020 23:02:20 +0000 (09:02 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 15 Sep 2020 12:13:27 +0000 (22:13 +1000)
The commentary at the call site seems to disagree with the code. The
conditional prevents calling set_thresholds() via the exception handler,
which appears to crash. Perhaps that's because it immediately triggers
another TAU exception. Anyway, calling set_thresholds() from TAUupdate()
is redundant because tau_timeout() does so.

Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2")
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/d7c7ee33232cf72a6a6bbb6ef05838b2e2b113c0.1599260540.git.fthain@telegraphics.com.au
arch/powerpc/kernel/tau_6xx.c

index 268205c..b8d7e7d 100644 (file)
@@ -110,11 +110,6 @@ static void TAUupdate(int cpu)
 #ifdef DEBUG
        printk("grew = %d\n", tau[cpu].grew);
 #endif
-
-#ifndef CONFIG_TAU_INT /* tau_timeout will do this if not using interrupts */
-       set_thresholds(cpu);
-#endif
-
 }
 
 #ifdef CONFIG_TAU_INT