Pass unhandled queries upstream instead of just dropping them (#326447). Also, fix...

Original commit message from CVS:
* ext/ogg/gstoggdemux.c: (gst_ogg_pad_query_types),
(gst_ogg_pad_src_query):
* ext/ogg/gstogmparse.c: (gst_ogm_parse_sink_query):
* ext/theora/theoradec.c: (theora_dec_src_query),
(theora_dec_sink_query):
* ext/vorbis/vorbisdec.c: (vorbis_dec_src_query),
(vorbis_dec_sink_query):
* ext/vorbis/vorbisenc.c: (gst_vorbisenc_src_query),
(gst_vorbisenc_sink_query):
* gst/adder/gstadder.c: (gst_adder_query):
Pass unhandled queries upstream instead of just
dropping them (#326447). Also, fix supported
query types list for some elements.

diff --git a/ChangeLog b/ChangeLog
index baa8b35..8147dcf 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,21 @@
 2006-02-01  Tim-Philipp Müller  <tim at centricular dot net>
 
+       * ext/ogg/gstoggdemux.c: (gst_ogg_pad_query_types),
+       (gst_ogg_pad_src_query):
+       * ext/ogg/gstogmparse.c: (gst_ogm_parse_sink_query):
+       * ext/theora/theoradec.c: (theora_dec_src_query),
+       (theora_dec_sink_query):
+       * ext/vorbis/vorbisdec.c: (vorbis_dec_src_query),
+       (vorbis_dec_sink_query):
+       * ext/vorbis/vorbisenc.c: (gst_vorbisenc_src_query),
+       (gst_vorbisenc_sink_query):
+       * gst/adder/gstadder.c: (gst_adder_query):
+         Pass unhandled queries upstream instead of just
+         dropping them (#326447). Also, fix supported
+         query types list for some elements.
+
+2006-02-01  Tim-Philipp Müller  <tim at centricular dot net>
+
        * gst/typefind/gsttypefindfunctions.c: (au_type_find),
        (paris_type_find), (ilbc_type_find), (plugin_init):
          Fix typefinding for audio/x-au, audio/x-paris and

diff --git a/ext/ogg/gstoggdemux.c b/ext/ogg/gstoggdemux.c
index 45d3a15..aa5cbce 100644 (file)
--- a/ext/ogg/gstoggdemux.c
+++ b/ext/ogg/gstoggdemux.c
@@ -339,7 +339,7 @@ static const GstQueryType *
 gst_ogg_pad_query_types (GstPad * pad)
 {
   static const GstQueryType query_types[] = {
-    GST_QUERY_POSITION,
+    GST_QUERY_DURATION,
     0
   };
 
@@ -378,12 +378,8 @@ gst_ogg_pad_src_query (GstPad * pad, GstQuery * query)
       gst_query_set_duration (query, GST_FORMAT_TIME, ogg->total_time);
       break;
     }
-    case GST_QUERY_CONVERT:
-      /* hmm .. */
-      res = FALSE;
-      break;
     default:
-      res = FALSE;
+      res = gst_pad_query_default (pad, query);
       break;
   }
 done:

diff --git a/ext/ogg/gstogmparse.c b/ext/ogg/gstogmparse.c
index 527c038..9bd03ca 100644 (file)
--- a/ext/ogg/gstogmparse.c
+++ b/ext/ogg/gstogmparse.c
@@ -524,7 +524,7 @@ gst_ogm_parse_sink_query (GstPad * pad, GstQuery * query)
       break;
     }
     default:
-      res = FALSE;
+      res = gst_pad_query_default (pad, query);
       break;
   }
   return res;

diff --git a/ext/theora/theoradec.c b/ext/theora/theoradec.c
index 26c0993..8b6de08 100644 (file)
--- a/ext/theora/theoradec.c
+++ b/ext/theora/theoradec.c
@@ -496,7 +496,7 @@ theora_dec_src_query (GstPad * pad, GstQuery * query)
       break;
     }
     default:
-      res = FALSE;
+      res = gst_pad_query_default (pad, query);
       break;
   }
   return res;
@@ -527,7 +527,7 @@ theora_dec_sink_query (GstPad * pad, GstQuery * query)
       break;
     }
     default:
-      res = FALSE;
+      res = gst_pad_query_default (pad, query);
       break;
   }
 

diff --git a/ext/vorbis/vorbisdec.c b/ext/vorbis/vorbisdec.c
index 042ead5..48c4f47 100644 (file)
--- a/ext/vorbis/vorbisdec.c
+++ b/ext/vorbis/vorbisdec.c
@@ -331,7 +331,7 @@ vorbis_dec_src_query (GstPad * pad, GstQuery * query)
       break;
     }
     default:
-      res = FALSE;
+      res = gst_pad_query_default (pad, query);
       break;
   }
   return res;
@@ -365,7 +365,7 @@ vorbis_dec_sink_query (GstPad * pad, GstQuery * query)
       break;
     }
     default:
-      res = FALSE;
+      res = gst_pad_query_default (pad, query);
       break;
   }
 error:

diff --git a/ext/vorbis/vorbisenc.c b/ext/vorbis/vorbisenc.c
index b211f4e..2904c80 100644 (file)
--- a/ext/vorbis/vorbisenc.c
+++ b/ext/vorbis/vorbisenc.c
@@ -475,7 +475,7 @@ gst_vorbisenc_src_query (GstPad * pad, GstQuery * query)
       break;
     }
     default:
-      res = FALSE;
+      res = gst_pad_query_default (pad, query);
       break;
   }
 
@@ -508,7 +508,7 @@ gst_vorbisenc_sink_query (GstPad * pad, GstQuery * query)
       break;
     }
     default:
-      res = FALSE;
+      res = gst_pad_query_default (pad, query);
       break;
   }
 

diff --git a/gst/adder/gstadder.c b/gst/adder/gstadder.c
index 86e30e4..c33f050 100644 (file)
--- a/gst/adder/gstadder.c
+++ b/gst/adder/gstadder.c
@@ -234,8 +234,10 @@ gst_adder_query (GstPad * pad, GstQuery * query)
       /* FIXME: what to do about the length? query all pads upstream and
        * pick the longest length? or the shortest length? or what? */
     case GST_QUERY_DURATION:
+      res = FALSE;
       break;
     default:
+      res = gst_pad_query_default (pad, query);
       break;
   }