projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d91234b
)
[clangd] Stop logging in fromJSON, report instead.
author
Sam McCall
<sam.mccall@gmail.com>
Fri, 9 Oct 2020 14:08:44 +0000
(16:08 +0200)
committer
Sam McCall
<sam.mccall@gmail.com>
Fri, 9 Oct 2020 14:15:45 +0000
(16:15 +0200)
clang-tools-extra/clangd/Protocol.cpp
patch
|
blob
|
history
diff --git
a/clang-tools-extra/clangd/Protocol.cpp
b/clang-tools-extra/clangd/Protocol.cpp
index
5d50a7b
..
f8aca22
100644
(file)
--- a/
clang-tools-extra/clangd/Protocol.cpp
+++ b/
clang-tools-extra/clangd/Protocol.cpp
@@
-851,7
+851,7
@@
static llvm::StringRef toTextKind(MarkupKind Kind) {
bool fromJSON(const llvm::json::Value &V, MarkupKind &K, llvm::json::Path P) {
auto Str = V.getAsString();
if (!Str) {
-
elog("Failed to parse markup kind: expected a
string");
+
P.report("expected
string");
return false;
}
if (*Str == "plaintext")
@@
-859,7
+859,7
@@
bool fromJSON(const llvm::json::Value &V, MarkupKind &K, llvm::json::Path P) {
else if (*Str == "markdown")
K = MarkupKind::Markdown;
else {
-
elog("Unknown markup kind: {0}", *Str
);
+
P.report("unknown markup kind"
);
return false;
}
return true;