sched/fair: Removed useless update of p->recent_used_cpu
authorVincent Guittot <vincent.guittot@linaro.org>
Tue, 28 Sep 2021 10:35:44 +0000 (12:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:01 +0000 (13:14 +0100)
[ Upstream commit a7ba894821b6ade7bb420455f87020b2838d6180 ]

Since commit 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu"),
p->recent_used_cpu is unconditionnaly set with prev.

Fixes: 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Mel Gorman <mgorman@suse.de>
Link: https://lkml.kernel.org/r/20210928103544.27489-1-vincent.guittot@linaro.org
Stable-dep-of: a2e7f03ed28f ("sched/uclamp: Make asym_fits_capacity() use util_fits_cpu()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/sched/fair.c

index 9e2c6e38342c6edc0517906b6d50e5961589bc8b..d706c1a8453abdbca4c78b8f9c5239e1ec8dc3e1 100644 (file)
@@ -6595,11 +6595,6 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target)
            (available_idle_cpu(recent_used_cpu) || sched_idle_cpu(recent_used_cpu)) &&
            cpumask_test_cpu(p->recent_used_cpu, p->cpus_ptr) &&
            asym_fits_capacity(task_util, recent_used_cpu)) {
-               /*
-                * Replace recent_used_cpu with prev as it is a potential
-                * candidate for the next wake:
-                */
-               p->recent_used_cpu = prev;
                return recent_used_cpu;
        }