rtc: bd70528: fix driver dependencies
authorMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Mon, 12 Aug 2019 06:36:11 +0000 (09:36 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 12 Aug 2019 21:01:25 +0000 (23:01 +0200)
With CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call
into the low-level functions that are part of the watchdog module:

drivers/rtc/rtc-bd70528.o: In function `bd70528_set_time':
rtc-bd70528.c:(.text+0x22c): undefined reference to `bd70528_wdt_lock'
rtc-bd70528.c:(.text+0x2a8): undefined reference to `bd70528_wdt_unlock'
drivers/rtc/rtc-bd70528.o: In function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x50c): undefined reference to `bd70528_wdt_set'

Add a Kconfig dependency which forces RTC to be a module if watchdog is a
module. If watchdog is not compiled at all the stub functions for watchdog
control are used. compiling the RTC without watchdog is fine.

Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Link: https://lore.kernel.org/r/84462e01e43d39024948a3bdd24087ff87dc2255.1565591387.git.matti.vaittinen@fi.rohmeurope.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/Kconfig

index 2805cbb..24d1603 100644 (file)
@@ -500,6 +500,7 @@ config RTC_DRV_M41T80_WDT
          watchdog timer in the ST M41T60 and M41T80 RTC chips series.
 config RTC_DRV_BD70528
        tristate "ROHM BD70528 PMIC RTC"
+       depends on MFD_ROHM_BD70528 && (BD70528_WATCHDOG || !BD70528_WATCHDOG)
        help
          If you say Y here you will get support for the RTC
          on ROHM BD70528 Power Management IC.