extcon: arizona: Clear existing button reports before reporting new one
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 1 Apr 2013 18:18:18 +0000 (19:18 +0100)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Tue, 2 Apr 2013 10:54:05 +0000 (11:54 +0100)
If the user moves directly from one button to another then we won't get a
no buttons pressed event and will therefore end up reporting that two
buttons are simultaneously pressed which isn't supported by the hardware.
Make sure we clear any existing button reports before reporting any new
ones.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/extcon/extcon-arizona.c

index e2d881a..26f9a1a 100644 (file)
@@ -852,6 +852,10 @@ static irqreturn_t arizona_micdet(int irq, void *data)
                        lvl = val & ARIZONA_MICD_LVL_MASK;
                        lvl >>= ARIZONA_MICD_LVL_SHIFT;
 
+                       for (i = 0; i < info->num_micd_ranges; i++)
+                               input_report_key(info->input,
+                                                info->micd_ranges[i].key, 0);
+
                        WARN_ON(!lvl);
                        WARN_ON(ffs(lvl) - 1 >= info->num_micd_ranges);
                        if (lvl && ffs(lvl) - 1 < info->num_micd_ranges) {