i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers
authorWan Jiabing <wanjiabing@vivo.com>
Wed, 27 Apr 2022 11:54:56 +0000 (19:54 +0800)
committerZhi Wang <zhi.a.wang@intel.com>
Thu, 28 Apr 2022 21:06:02 +0000 (17:06 -0400)
Fix following coccicheck error:
./drivers/gpu/drm/i915/gvt/handlers.c:2925:35-41: ERROR: block is NULL but dereferenced.

Use gvt->mmio.mmio_block instead of block to avoid NULL pointer
dereference when find_mmio_block returns NULL.

Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220427115457.836729-1-wanjiabing@vivo.com
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
drivers/gpu/drm/i915/gvt/handlers.c

index 3ce1a5a9e2dae645702293360287cee66ba1b741..ad31640c9bf229e8357bd62eeab5f9a90b160e83 100644 (file)
@@ -2916,7 +2916,7 @@ static int init_mmio_block_handlers(struct intel_gvt *gvt)
        block = find_mmio_block(gvt, VGT_PVINFO_PAGE);
        if (!block) {
                WARN(1, "fail to assign handlers to mmio block %x\n",
-                    i915_mmio_reg_offset(block->offset));
+                    i915_mmio_reg_offset(gvt->mmio.mmio_block->offset));
                return -ENODEV;
        }