scsi: elx: efct: Fix error handling in efct_hw_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 17 Jun 2021 02:48:37 +0000 (02:48 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 19 Jun 2021 03:01:03 +0000 (23:01 -0400)
Fix to return negative error code -ENOMEM from the error handling case
instead of 0. Also fix typo in error message.

Link: https://lore.kernel.org/r/20210617024837.1023069-1-weiyongjun1@huawei.com
Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/efct/efct_hw.c

index ce4736c..6324683 100644 (file)
@@ -1044,8 +1044,8 @@ efct_hw_init(struct efct_hw *hw)
         */
        hw->wq_reqtag_pool = efct_hw_reqtag_pool_alloc(hw);
        if (!hw->wq_reqtag_pool) {
-               efc_log_err(hw->os, "efct_hw_reqtag_init failed %d\n", rc);
-               return rc;
+               efc_log_err(hw->os, "efct_hw_reqtag_pool_alloc failed\n");
+               return -ENOMEM;
        }
 
        rc = efct_hw_setup_io(hw);