extcon: intel-mrfld: Sync hardware and software state on init
authorFerry Toth <ftoth@exalondelft.nl>
Tue, 18 May 2021 21:27:09 +0000 (23:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 07:45:00 +0000 (09:45 +0200)
commit ecb5bdff901139850fb3ca3ae2d0cccac045bc52 upstream.

extcon driver for Basin Cove PMIC shadows the switch status used for dwc3
DRD to detect a change in the switch position. This change initializes the
status at probe time.

Cc: stable@vger.kernel.org
Fixes: 492929c54791 ("extcon: mrfld: Introduce extcon driver for Basin Cove PMIC")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/extcon/extcon-intel-mrfld.c

index f47016f..cd1a5f2 100644 (file)
@@ -197,6 +197,7 @@ static int mrfld_extcon_probe(struct platform_device *pdev)
        struct intel_soc_pmic *pmic = dev_get_drvdata(dev->parent);
        struct regmap *regmap = pmic->regmap;
        struct mrfld_extcon_data *data;
+       unsigned int status;
        unsigned int id;
        int irq, ret;
 
@@ -244,6 +245,14 @@ static int mrfld_extcon_probe(struct platform_device *pdev)
        /* Get initial state */
        mrfld_extcon_role_detect(data);
 
+       /*
+        * Cached status value is used for cable detection, see comments
+        * in mrfld_extcon_cable_detect(), we need to sync cached value
+        * with a real state of the hardware.
+        */
+       regmap_read(regmap, BCOVE_SCHGRIRQ1, &status);
+       data->status = status;
+
        mrfld_extcon_clear(data, BCOVE_MIRQLVL1, BCOVE_LVL1_CHGR);
        mrfld_extcon_clear(data, BCOVE_MCHGRIRQ1, BCOVE_CHGRIRQ_ALL);