Fix use-after-free in _free_pending_clip()

https://bugzilla.gnome.org/show_bug.cgi?id=725855

diff --git a/ges/ges-base-xml-formatter.c b/ges/ges-base-xml-formatter.c
index 5edb89d..3758a78 100644 (file)
--- a/ges/ges-base-xml-formatter.c
+++ b/ges/ges-base-xml-formatter.c
@@ -537,7 +537,6 @@ _free_pending_effect (PendingEffects * pend)
 static void
 _free_pending_clip (GESBaseXmlFormatterPrivate * priv, PendingClip * pend)
 {
-  g_free (pend->id);
   gst_object_unref (pend->layer);
   if (pend->properties)
     gst_structure_free (pend->properties);
@@ -545,6 +544,7 @@ _free_pending_clip (GESBaseXmlFormatterPrivate * priv, PendingClip * pend)
   g_list_free_full (pend->pending_bindings,
       (GDestroyNotify) _free_pending_binding);
   g_hash_table_remove (priv->clipid_pendings, pend->id);
+  g_free (pend->id);
   g_slice_free (PendingClip, pend);
 }