compiler/types: Don't duplicate empty string
authorCaio Oliveira <caio.oliveira@intel.com>
Fri, 1 Sep 2023 07:16:04 +0000 (00:16 -0700)
committerMarge Bot <emma+marge@anholt.net>
Tue, 12 Sep 2023 23:18:12 +0000 (23:18 +0000)
We can use the static version of the empty string.  There's no worry
about freeing that string incorrectly since what is being deallocated
later is the whole mem_ctx.

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25160>

src/compiler/glsl_types.cpp

index d04fbd3..7172ca1 100644 (file)
@@ -178,7 +178,7 @@ glsl_type::glsl_type(const glsl_type *return_type,
    this->mem_ctx = ralloc_context(NULL);
    assert(this->mem_ctx != NULL);
 
-   this->name = ralloc_strdup(this->mem_ctx, "");
+   this->name = "";
 
    this->fields.parameters = rzalloc_array(this->mem_ctx,
                                            glsl_function_param, num_params + 1);