listkids() can be static in op.c

p4raw-id: //depot/perl@34920

diff --git a/embed.fnc b/embed.fnc
index 8cb9b81..9e42eac 100644 (file)
--- a/embed.fnc
+++ b/embed.fnc
@@ -447,9 +447,10 @@ Ap |void   |op_refcnt_lock
 Ap     |void   |op_refcnt_unlock
 #if defined(PERL_IN_OP_C)
 s      |OP*    |linklist       |NN OP *o
+s      |OP*    |listkids       |NULLOK OP* o
 #endif
+: This is used in S_doeval in pp_ctl.c
 p      |OP*    |list           |NULLOK OP* o
-p      |OP*    |listkids       |NULLOK OP* o
 Apd    |void   |load_module|U32 flags|NN SV* name|NULLOK SV* ver|...
 Ap     |void   |vload_module|U32 flags|NN SV* name|NULLOK SV* ver|NULLOK va_list* args
 p      |OP*    |localize       |NN OP *o|I32 lex

diff --git a/embed.h b/embed.h
index 71a5e5f..a0f2776 100644 (file)
--- a/embed.h
+++ b/embed.h
@@ -397,11 +397,11 @@
 #if defined(PERL_IN_OP_C)
 #ifdef PERL_CORE
 #define linklist               S_linklist
+#define listkids               S_listkids
 #endif
 #endif
 #ifdef PERL_CORE
 #define list                   Perl_list
-#define listkids               Perl_listkids
 #endif
 #define load_module            Perl_load_module
 #define vload_module           Perl_vload_module
@@ -2722,11 +2722,11 @@
 #if defined(PERL_IN_OP_C)
 #ifdef PERL_CORE
 #define linklist(a)            S_linklist(aTHX_ a)
+#define listkids(a)            S_listkids(aTHX_ a)
 #endif
 #endif
 #ifdef PERL_CORE
 #define list(a)                        Perl_list(aTHX_ a)
-#define listkids(a)            Perl_listkids(aTHX_ a)
 #endif
 #define vload_module(a,b,c,d)  Perl_vload_module(aTHX_ a,b,c,d)
 #ifdef PERL_CORE

diff --git a/op.c b/op.c
index dff969e..9c278df 100644 (file)
--- a/op.c
+++ b/op.c
@@ -1208,7 +1208,7 @@ Perl_scalarvoid(pTHX_ OP *o)
 }
 
 OP *
-Perl_listkids(pTHX_ OP *o)
+S_listkids(pTHX_ OP *o)
 {
     if (o && o->op_flags & OPf_KIDS) {
         OP *kid;

diff --git a/proto.h b/proto.h
index 22efaf0..7aa2243 100644 (file)
--- a/proto.h
+++ b/proto.h
@@ -1452,9 +1452,9 @@ STATIC OP*        S_linklist(pTHX_ OP *o)
 #define PERL_ARGS_ASSERT_LINKLIST      \
        assert(o)
 
+STATIC OP*     S_listkids(pTHX_ OP* o);
 #endif
 PERL_CALLCONV OP*      Perl_list(pTHX_ OP* o);
-PERL_CALLCONV OP*      Perl_listkids(pTHX_ OP* o);
 PERL_CALLCONV void     Perl_load_module(pTHX_ U32 flags, SV* name, SV* ver, ...)
                        __attribute__nonnull__(pTHX_2);
 #define PERL_ARGS_ASSERT_LOAD_MODULE   \