staging: r8188eu: remove unnecessary memset in r8188eu
authorWan Jiabing <wanjiabing@vivo.com>
Fri, 18 Mar 2022 09:24:48 +0000 (17:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Mar 2022 12:45:09 +0000 (13:45 +0100)
psetauthparm and precvpriv->pallocated_recv_buf are allocated by kzalloc().
It is unnecessary to call memset again.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20220318092459.519225-1-wanjiabing@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme.c
drivers/staging/r8188eu/hal/rtl8188eu_recv.c

index 8d36ab9..6f0bff1 100644 (file)
@@ -1521,7 +1521,6 @@ int rtw_set_auth(struct adapter *adapter, struct security_priv *psecuritypriv)
                res = _FAIL;
                goto exit;
        }
-       memset(psetauthparm, 0, sizeof(struct setauth_parm));
        psetauthparm->mode = (unsigned char)psecuritypriv->dot11AuthAlgrthm;
        pcmd->cmdcode = _SetAuth_CMD_;
        pcmd->parmbuf = (unsigned char *)psetauthparm;
index 322b454..727e1ad 100644 (file)
@@ -31,7 +31,6 @@ int   rtl8188eu_init_recv_priv(struct adapter *padapter)
                res = _FAIL;
                goto exit;
        }
-       memset(precvpriv->pallocated_recv_buf, 0, NR_RECVBUFF * sizeof(struct recv_buf) + 4);
 
        precvpriv->precv_buf = (u8 *)N_BYTE_ALIGMENT((size_t)(precvpriv->pallocated_recv_buf), 4);