kasan: test: make use of kunit_skip()
authorMarco Elver <elver@google.com>
Fri, 25 Jun 2021 06:58:15 +0000 (23:58 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 25 Jun 2021 17:31:03 +0000 (11:31 -0600)
Make use of the recently added kunit_skip() to skip tests, as it permits
TAP parsers to recognize if a test was deliberately skipped.

Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: David Gow <davidgow@google.com>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/test_kasan.c

index cacbbbd..0a2029d 100644 (file)
@@ -111,17 +111,13 @@ static void kasan_test_exit(struct kunit *test)
 } while (0)
 
 #define KASAN_TEST_NEEDS_CONFIG_ON(test, config) do {                  \
-       if (!IS_ENABLED(config)) {                                      \
-               kunit_info((test), "skipping, " #config " required");   \
-               return;                                                 \
-       }                                                               \
+       if (!IS_ENABLED(config))                                        \
+               kunit_skip((test), "Test requires " #config "=y");      \
 } while (0)
 
 #define KASAN_TEST_NEEDS_CONFIG_OFF(test, config) do {                 \
-       if (IS_ENABLED(config)) {                                       \
-               kunit_info((test), "skipping, " #config " enabled");    \
-               return;                                                 \
-       }                                                               \
+       if (IS_ENABLED(config))                                         \
+               kunit_skip((test), "Test requires " #config "=n");      \
 } while (0)
 
 static void kmalloc_oob_right(struct kunit *test)