usb: xhci-mtk: use bitfield instead of bool
authorChunfeng Yun <chunfeng.yun@mediatek.com>
Fri, 7 May 2021 02:11:24 +0000 (10:11 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 10 May 2021 14:21:48 +0000 (16:21 +0200)
Use bitfield instead of bool in struct

Refer to coding-style.rst 17) Using bool:
"If a structure has many true/false values, consider consolidating
them into a bitfield with 1 bit members, or using an appropriate
fixed width type, such as u8."

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/20210507021127.54717-1-chunfeng.yun@mediatek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-mtk.h

index cd3a37b..94a59b3 100644 (file)
@@ -138,17 +138,17 @@ struct xhci_hcd_mtk {
        struct mu3h_sch_bw_info *sch_array;
        struct list_head bw_ep_chk_list;
        struct mu3c_ippc_regs __iomem *ippc_regs;
-       bool has_ippc;
        int num_u2_ports;
        int num_u3_ports;
        int u3p_dis_msk;
        struct regulator *vusb33;
        struct regulator *vbus;
        struct clk_bulk_data clks[BULK_CLKS_NUM];
-       bool lpm_support;
-       bool u2_lpm_disable;
+       unsigned int has_ippc:1;
+       unsigned int lpm_support:1;
+       unsigned int u2_lpm_disable:1;
        /* usb remote wakeup */
-       bool uwk_en;
+       unsigned int uwk_en:1;
        struct regmap *uwk;
        u32 uwk_reg_base;
        u32 uwk_vers;