kgdb: fix gcc-11 warning on indentation
authorArnd Bergmann <arnd@arndb.de>
Mon, 22 Mar 2021 16:43:03 +0000 (17:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Mar 2021 07:26:29 +0000 (08:26 +0100)
gcc-11 starts warning about misleading indentation inside of macros:

drivers/misc/kgdbts.c: In function ‘kgdbts_break_test’:
drivers/misc/kgdbts.c:103:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
  103 |         if (verbose > 1) \
      |         ^~
drivers/misc/kgdbts.c:200:9: note: in expansion of macro ‘v2printk’
  200 |         v2printk("kgdbts: breakpoint complete\n");
      |         ^~~~~~~~
drivers/misc/kgdbts.c:105:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  105 |                 touch_nmi_watchdog();   \
      |                 ^~~~~~~~~~~~~~~~~~

The code looks correct to me, so just reindent it for readability.

Fixes: e8d31c204e36 ("kgdb: add kgdb internal test suite")
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210322164308.827846-1-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/kgdbts.c

index 945701b..2e081a5 100644 (file)
 
 #include <asm/sections.h>
 
-#define v1printk(a...) do { \
-       if (verbose) \
-               printk(KERN_INFO a); \
-       } while (0)
-#define v2printk(a...) do { \
-       if (verbose > 1) \
-               printk(KERN_INFO a); \
-               touch_nmi_watchdog();   \
-       } while (0)
-#define eprintk(a...) do { \
-               printk(KERN_ERR a); \
-               WARN_ON(1); \
-       } while (0)
+#define v1printk(a...) do {            \
+       if (verbose)                    \
+               printk(KERN_INFO a);    \
+} while (0)
+#define v2printk(a...) do {            \
+       if (verbose > 1)                \
+               printk(KERN_INFO a);    \
+       touch_nmi_watchdog();           \
+} while (0)
+#define eprintk(a...) do {             \
+       printk(KERN_ERR a);             \
+       WARN_ON(1);                     \
+} while (0)
 #define MAX_CONFIG_LEN         40
 
 static struct kgdb_io kgdbts_io_ops;