cxl: Rework error message for incompatible slots
authorFrederic Barrat <fbarrat@linux.ibm.com>
Tue, 7 Apr 2020 11:56:01 +0000 (13:56 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 24 Aug 2020 15:31:32 +0000 (01:31 +1000)
Improve the error message shown if a capi adapter is plugged on a
capi-incompatible slot directly under the PHB (no intermediate switch).

Fixes: 5632874311db ("cxl: Add support for POWER9 DD2")
Cc: stable@vger.kernel.org # 4.14+
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200407115601.25453-1-fbarrat@linux.ibm.com
drivers/misc/cxl/pci.c

index 25a9dd9..2ba899f 100644 (file)
@@ -393,8 +393,8 @@ int cxl_calc_capp_routing(struct pci_dev *dev, u64 *chipid,
        *capp_unit_id = get_capp_unit_id(np, *phb_index);
        of_node_put(np);
        if (!*capp_unit_id) {
-               pr_err("cxl: invalid capp unit id (phb_index: %d)\n",
-                      *phb_index);
+               pr_err("cxl: No capp unit found for PHB[%lld,%d]. Make sure the adapter is on a capi-compatible slot\n",
+                      *chipid, *phb_index);
                return -ENODEV;
        }