usb: dwc3: gadget: fix XferNotReady debug print
authorFelipe Balbi <balbi@ti.com>
Wed, 18 Jan 2012 15:06:03 +0000 (17:06 +0200)
committerFelipe Balbi <balbi@ti.com>
Mon, 6 Feb 2012 09:48:28 +0000 (11:48 +0200)
Only bit 3 of the event status bitfield is valid
and the others should not be considered.

Make sure SW matches documentation on that case
to avoid bogus debugging prints which would
confuse an engineer.

Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/core.h
drivers/usb/dwc3/gadget.c

index 9e57f8e..f4878c4 100644 (file)
@@ -719,6 +719,11 @@ struct dwc3_event_depevt {
        u32     endpoint_event:4;
        u32     reserved11_10:2;
        u32     status:4;
+
+/* Within XferNotReady */
+#define DEPEVT_STATUS_TRANSFER_ACTIVE  (1 << 3)
+
+/* Within XferComplete */
 #define DEPEVT_STATUS_BUSERR    (1 << 0)
 #define DEPEVT_STATUS_SHORT     (1 << 1)
 #define DEPEVT_STATUS_IOC       (1 << 2)
index e0e2337..4b64dc0 100644 (file)
@@ -1657,7 +1657,8 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,
                        int ret;
 
                        dev_vdbg(dwc->dev, "%s: reason %s\n",
-                                       dep->name, event->status
+                                       dep->name, event->status &
+                                       DEPEVT_STATUS_TRANSFER_ACTIVE
                                        ? "Transfer Active"
                                        : "Transfer Not Active");