ALSA: hda: cs35l41: Fix the loop check in cs35l41_add_dsd_properties
authorTakashi Iwai <tiwai@suse.de>
Wed, 16 Aug 2023 06:35:25 +0000 (08:35 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 16 Aug 2023 06:36:07 +0000 (08:36 +0200)
model->hid is a pointer, and should be rather NULL-checked in the loop
of cs35l41_prop_model_table.

Fixes: ef4ba63f12b0 ("ALSA: hda: cs35l41: Support systems with missing _DSD properties")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308160506.8lCEeFDG-lkp@intel.com/
Link: https://lore.kernel.org/r/20230816063525.23009-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l41_hda_property.c

index 673f232..48dcc3f 100644 (file)
@@ -61,7 +61,7 @@ int cs35l41_add_dsd_properties(struct cs35l41_hda *cs35l41, struct device *physd
 {
        const struct cs35l41_prop_model *model;
 
-       for (model = cs35l41_prop_model_table; model->hid > 0; model++) {
+       for (model = cs35l41_prop_model_table; model->hid; model++) {
                if (!strcmp(model->hid, hid) &&
                    (!model->ssid ||
                     (cs35l41->acpi_subsystem_id &&