projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5bd3c1c
)
dmaengine: xilinx_dma: call of_node_put() when breaking out of for_each_child_of_node()
author
Liu Shixin
<liushixin2@huawei.com>
Tue, 22 Nov 2022 02:16:12 +0000
(10:16 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:27:13 +0000
(08:27 +0100)
[ Upstream commit
596b53ccc36a546ab28e8897315c5b4d1d5a0200
]
Since for_each_child_of_node() will increase the refcount of node, we need
to call of_node_put() manually when breaking out of the iteration.
Fixes:
9cd4360de609
("dma: Add Xilinx AXI Video Direct Memory Access Engine driver support")
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
Link:
https://lore.kernel.org/r/20221122021612.1908866-1-liushixin2@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/xilinx/xilinx_dma.c
patch
|
blob
|
history
diff --git
a/drivers/dma/xilinx/xilinx_dma.c
b/drivers/dma/xilinx/xilinx_dma.c
index
4273150
..
edc2bb8
100644
(file)
--- a/
drivers/dma/xilinx/xilinx_dma.c
+++ b/
drivers/dma/xilinx/xilinx_dma.c
@@
-3138,8
+3138,10
@@
static int xilinx_dma_probe(struct platform_device *pdev)
/* Initialize the channels */
for_each_child_of_node(node, child) {
err = xilinx_dma_child_probe(xdev, child);
- if (err < 0)
+ if (err < 0) {
+ of_node_put(child);
goto error;
+ }
}
if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) {