scsi: target: iblock: Quiet bool conversion warning with pr_preempt use
authorMike Christie <michael.christie@oracle.com>
Fri, 23 Jun 2023 16:11:36 +0000 (11:11 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 29 Jun 2023 01:58:36 +0000 (21:58 -0400)
We want to pass in true for pr_preempt's argument if we are doing a
PRO_PREEMPT_AND_ABORT, so just test sa against PRO_PREEMPT_AND_ABORT, and
pass the result directly to pr_preempt.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306221655.Kwtqi1gI-lkp@intel.com/
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Link: https://lore.kernel.org/r/20230623161136.6270-1-michael.christie@oracle.com
Reviewed-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_iblock.c

index e6029ea..a023cc4 100644 (file)
@@ -889,7 +889,7 @@ static sense_reason_t iblock_execute_pr_out(struct se_cmd *cmd, u8 sa, u64 key,
 
                ret = ops->pr_preempt(bdev, key, sa_key,
                                      scsi_pr_type_to_block(type),
-                                     sa == PRO_PREEMPT ? false : true);
+                                     sa == PRO_PREEMPT_AND_ABORT);
                break;
        case PRO_RELEASE:
                if (!ops->pr_clear) {