ALSA: ice1724 - Fix IRQ register initialization
authorTakashi Iwai <tiwai@suse.de>
Sat, 1 Nov 2008 10:01:50 +0000 (11:01 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 1 Nov 2008 10:03:52 +0000 (11:03 +0100)
The IRQMASK register has to be set to zero expclitily at the initialization
otherwise you'll get no interrupts properly at later operations.

Also, removed the old commented out codes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ice1712/ice1724.c

index 79a9cd0..40725df 100644 (file)
@@ -2353,7 +2353,6 @@ static int __devinit snd_vt1724_create(struct snd_card *card,
 {
        struct snd_ice1712 *ice;
        int err;
-       /* unsigned char mask; */
        static struct snd_device_ops ops = {
                .dev_free =     snd_vt1724_dev_free,
        };
@@ -2414,11 +2413,9 @@ static int __devinit snd_vt1724_create(struct snd_card *card,
                return -EIO;
        }
 
-       /* unmask used interrupts */
-#if 0 /* these are enabled/disabled dynamically */
-       mask = VT1724_IRQ_MPU_RX | VT1724_IRQ_MPU_TX;
-       outb(mask, ICEREG1724(ice, IRQMASK));
-#endif
+       /* clear interrupts -- otherwise you'll get irq problems later */
+       outb(0, ICEREG1724(ice, IRQMASK));
+
        /* don't handle FIFO overrun/underruns (just yet),
         * since they cause machine lockups
         */