Bug 662524 - POP3: Use a safer default value for "delete-after-days"
authorMatthew Barnes <mbarnes@redhat.com>
Tue, 25 Oct 2011 15:08:10 +0000 (11:08 -0400)
committerMatthew Barnes <mbarnes@redhat.com>
Tue, 25 Oct 2011 15:10:33 +0000 (11:10 -0400)
Default to not deleting mail kept on the POP3 server at all rather than
automatically deleting after X days.  Helps avoid accidental data loss.

camel/providers/pop3/camel-pop3-settings.c

index 85be9fa..070e421 100644 (file)
@@ -205,6 +205,8 @@ camel_pop3_settings_class_init (CamelPOP3SettingsClass *class)
                PROP_AUTH_MECHANISM,
                "auth-mechanism");
 
+       /* Default to 0 days (i.e. do not delete) so we don't delete
+        * mail on the POP server when the user's not expecting it. */
        g_object_class_install_property (
                object_class,
                PROP_DELETE_AFTER_DAYS,
@@ -214,7 +216,7 @@ camel_pop3_settings_class_init (CamelPOP3SettingsClass *class)
                        "Delete messages left on server after N days",
                        0,
                        365,
-                       7,
+                       0,
                        G_PARAM_READWRITE |
                        G_PARAM_CONSTRUCT |
                        G_PARAM_STATIC_STRINGS));