Based on part of a patch from Thomas Zimmermann.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=98191
*/
switch (seed % 3)
{
+ default:
+ /* don't alter it */
+ break;
case 1:
len += 2;
break;
i = 0;
while (i < _dbus_string_get_length (result))
{
- switch (_dbus_string_get_byte (result, i))
+ unsigned char c = _dbus_string_get_byte (result, i);
+
+ switch (c)
{
case 'A':
_dbus_string_set_byte (result, i, 'a');
_dbus_string_delete (result, i, 1);
--i; /* to offset ++i below */
break;
+ default:
+ if ((c < '0' || c > '9') && (c < 'a' || c > 'f'))
+ _dbus_assert_not_reached ("invalid SHA-1 test script");
}
++i;
break;
+ case TEST_USER_ME:
+ /* cannot get here, fall through */
default:
g_assert_not_reached ();
}
case TEST_USER_ME:
return test_connect_to_bus (ctx, address);
- default:
+ case TEST_USER_ROOT:
+ case TEST_USER_MESSAGEBUS:
+ case TEST_USER_OTHER:
g_test_skip ("setresuid() not available, or unsure about "
"credentials-passing semantics on this platform");
return NULL;
+
+ default:
+ g_return_val_if_reached (NULL);
}
#endif
break;
case SOCKET_UNLINKED:
+ default:
fprintf (stderr, "Bad status from open_socket(), should not happen\n");
exit (1);
break;
strerror (errno));
exit (1);
break;
+ default:
+ _dbus_assert_not_reached ("Invalid read result");
}
verbose ("Got PID %ld from daemon\n",
strerror (errno));
exit (1);
break;
+ default:
+ _dbus_assert_not_reached ("Invalid read result");
}
close (bus_address_to_launcher_pipe[READ_END]);
strerror (errno));
exit (1);
break;
+ default:
+ _dbus_assert_not_reached ("Invalid read result");
}
end = NULL;
#include <config.h>
-#include "dbus/dbus-internals.h" /* just for the macros */
+#include "dbus/dbus-internals.h"
#include <stdio.h>
#include <stdlib.h>
}
break;
+ case BINARY_MODE_NOT:
+ _dbus_assert_not_reached ("wrong filter function");
+ break;
+
case BINARY_MODE_RAW:
default:
/* nothing special, just the raw message stream */
case DBUS_BUS_SESSION:
where = "session bus";
break;
+ case DBUS_BUS_STARTER:
default:
- where = "";
+ /* We don't set type to anything else */
+ _dbus_assert_not_reached ("impossible bus type");
}
}
fprintf (stderr, "Failed to open connection to %s: %s\n",
#include <signal.h>
#include "dbus/dbus.h"
+#include "dbus/dbus-internals.h"
#define MAX_ADDR_LEN 512
#define PIPE_READ_END 0
me, strerror (errno));
return 127;
break;
+
+ default:
+ _dbus_assert_not_reached ("invalid read result");
}
close (bus_address_pipe[PIPE_READ_END]);