usb: typec: tcpm: update power supply once partner accepts
authorBadhri Jagan Sridharan <badhri@google.com>
Wed, 7 Apr 2021 20:07:20 +0000 (13:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 Apr 2021 13:21:25 +0000 (15:21 +0200)
power_supply_changed needs to be called to notify clients
after the partner accepts the requested values for the pps
case.

Also, remove the redundant power_supply_changed at the end
of the tcpm_reset_port as power_supply_changed is already
called right after usb_type is changed.

Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through power_supply")
Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20210407200723.1914388-3-badhri@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpm.c

index b4a4009..d1d03ee 100644 (file)
@@ -2568,6 +2568,7 @@ static void tcpm_pd_ctrl_request(struct tcpm_port *port,
                        port->pps_data.max_curr = port->pps_data.req_max_curr;
                        port->req_supply_voltage = port->pps_data.req_out_volt;
                        port->req_current_limit = port->pps_data.req_op_curr;
+                       power_supply_changed(port->psy);
                        tcpm_set_state(port, SNK_TRANSITION_SINK, 0);
                        break;
                case SOFT_RESET_SEND:
@@ -3136,7 +3137,6 @@ static unsigned int tcpm_pd_select_pps_apdo(struct tcpm_port *port)
                                                      port->pps_data.req_out_volt));
                port->pps_data.req_op_curr = min(port->pps_data.max_curr,
                                                 port->pps_data.req_op_curr);
-               power_supply_changed(port->psy);
        }
 
        return src_pdo;
@@ -3561,8 +3561,6 @@ static void tcpm_reset_port(struct tcpm_port *port)
        port->sink_cap_done = false;
        if (port->tcpc->enable_frs)
                port->tcpc->enable_frs(port->tcpc, false);
-
-       power_supply_changed(port->psy);
 }
 
 static void tcpm_detach(struct tcpm_port *port)