regulator: core: Always warn when using a dummy regulator
authorMark Brown <broonie@linaro.org>
Fri, 4 Oct 2013 10:42:53 +0000 (11:42 +0100)
committerMark Brown <broonie@linaro.org>
Fri, 4 Oct 2013 10:47:15 +0000 (11:47 +0100)
This helps people spot if they have missed a supply from a device tree or
equivalent data structure.

Suggested-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/core.c

index a40055e..82805e2 100644 (file)
@@ -1281,13 +1281,8 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
         * even if it isn't hooked up and just provide a dummy.
         */
        if (has_full_constraints && allow_dummy) {
-               /*
-                * Log the substitution if regulator configuration is
-                * not complete to help development.
-                */
-               if (!has_full_constraints)
-                       pr_warn("%s supply %s not found, using dummy regulator\n",
-                               devname, id);
+               pr_warn("%s supply %s not found, using dummy regulator\n",
+                       devname, id);
 
                rdev = dummy_regulator_rdev;
                goto found;