Categorize PolicyBucket unit tests

Categorize into positive/negative test cases.

Change-Id: I7f289446a33303cd1e2f1845a925176b6f294aef

diff --git a/test/common/types/policybucket.cpp b/test/common/types/policybucket.cpp
index 816b21e1f86c97ffd080ab08bfb87db945693eaa..cf5a1f83bb78131fad8e2fd01ffe7cbcc3d149de 100644 (file)
--- a/test/common/types/policybucket.cpp
+++ b/test/common/types/policybucket.cpp
@@ -69,8 +69,8 @@ protected:
     };
 
     const std::vector<PolicyBucketId> badIds = {
-        "{badid", "bad[id", "badid~", "/badid", "bad*id", "badid|", "badid;", "\tbadid", "badid\n",
-        " badid", "bad id", "badid "
+        "{badid", "bad[id", "badid~", "/badid", "bad*id", "badid|", "badid;", "\tbadid",
+        "badid\n", " badid", "bad id", "badid "
     };
 };
 
@@ -164,9 +164,8 @@ TEST_F(PolicyBucketFixture, FilteredWildcardNonePositive) {
  * - PolicyBucket constructor should not throw any exception
  */
 TEST_F(PolicyBucketFixture, BucketIdValidationPositive) {
-    for (auto it = goodIds.begin(); it != goodIds.end(); ++it) {
-        SCOPED_TRACE(*it);
-        ASSERT_NO_THROW(PolicyBucket(PolicyBucketId(*it)));
+    for (auto &bucketId : goodIds) {
+        ASSERT_NO_THROW(PolicyBucket{bucketId});
     }
 }
 
@@ -177,8 +176,7 @@ TEST_F(PolicyBucketFixture, BucketIdValidationPositive) {
  * - PolicyBucket constructor should throw an exception every time it is called
  */
 TEST_F(PolicyBucketFixture, BucketIdValidationNegative) {
-    for (auto it = badIds.begin(); it != badIds.end(); ++it) {
-        SCOPED_TRACE(*it);
-        ASSERT_THROW(PolicyBucket(PolicyBucketId(*it)), InvalidBucketIdException);
+    for (auto &bucketId : badIds) {
+        ASSERT_THROW(PolicyBucket{bucketId}, InvalidBucketIdException);
     }
 }