ASoC: SOF: Intel: hda-dai: Drop misleading comment regarding dma_data
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Tue, 12 Jul 2022 13:16:19 +0000 (16:16 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 12 Jul 2022 13:22:57 +0000 (14:22 +0100)
The comment in hda_link_dma_hw_params() is no longer valid as the dma_data
is set to NULL at system suspend as well.

Instead of rewording the comment to state the obvious: try to take the
hext_stream from the dma_data and if it is not set then assign a new one
and store it as dma_data.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20220712131620.13365-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-dai.c

index ed74a1f..9015ca2 100644 (file)
@@ -221,7 +221,6 @@ static int hda_link_dma_hw_params(struct snd_pcm_substream *substream,
        struct hdac_bus *bus = hstream->bus;
        struct hdac_ext_link *link;
 
-       /* get stored dma data if resuming from system suspend */
        hext_stream = snd_soc_dai_get_dma_data(cpu_dai, substream);
        if (!hext_stream) {
                hext_stream = hda_link_stream_assign(bus, substream);