elm_prefs.c: dereference variable in a proper place.
authorDaniel Juyung Seo <seojuyung2@gmail.com>
Sun, 11 Aug 2013 08:13:17 +0000 (17:13 +0900)
committerDaniel Juyung Seo <seojuyung2@gmail.com>
Sun, 11 Aug 2013 08:13:17 +0000 (17:13 +0900)
This fixes coverity CID 1040034 : Dereference after null check (FORWARD_NULL).

src/lib/elm_prefs.c

index e3a2d208f412548afffccfc1ca0c45b4cd03c7e3..92139d39f8147916b2a892d89068e5eac6b11fe9 100644 (file)
@@ -959,8 +959,8 @@ _elm_prefs_page_load(Evas_Object *obj,
 
         if (!ret)
           ERR("problem while reading from file %s, key %s", sd->file, pname);
-
-        ret->prefs = obj;
+        else
+          ret->prefs = obj;
      }
    else
      ERR("failed to load from requested epb file (%s)", sd->file);