coresight: etm4x: Fix issues within reset interface of sysfs
authorJonathan Zhou <jonathan.zhouwen@huawei.com>
Wed, 16 Sep 2020 19:17:29 +0000 (13:17 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Sep 2020 16:46:04 +0000 (18:46 +0200)
The member @nr_addr_cmp is not a bool value, using operator '>'
instead to avoid unexpected failure.

Fixes: a77de2637c9e ("coresight: etm4x: moving sysFS entries to a dedicated file")
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Shaokun Zhang <zhangshaokun@hisilicon.com>
Signed-off-by: Jonathan Zhou <jonathan.zhouwen@huawei.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20200916191737.4001561-9-mathieu.poirier@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/coresight/coresight-etm4x-sysfs.c

index b673e73..a588cd6 100644 (file)
@@ -206,7 +206,7 @@ static ssize_t reset_store(struct device *dev,
         * each trace run.
         */
        config->vinst_ctrl = BIT(0);
-       if (drvdata->nr_addr_cmp == true) {
+       if (drvdata->nr_addr_cmp > 0) {
                config->mode |= ETM_MODE_VIEWINST_STARTSTOP;
                /* SSSTATUS, bit[9] */
                config->vinst_ctrl |= BIT(9);