don't put strerror in translatable message

Original commit message from CVS:

don't put strerror in translatable message

diff --git a/ChangeLog b/ChangeLog
index 68200ac8e14c720f45138f1446bd18d6301c3760..b25524e6a974270311581db1726447127b62f5f5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2006-11-04  Thomas Vander Stichele  <thomas at apestaart dot org>
+
+       * plugins/elements/gstfilesrc.c: (gst_file_src_start):
+         I'm considering shooting the next person to put strerror stuff
+         in the translateable part of the message.
+
 2006-11-03  Wim Taymans  <wim@fluendo.com>
 
        * plugins/elements/gstfdsrc.c: (gst_fd_src_create):

diff --git a/docs/random/moving-plugins b/docs/random/moving-plugins
index de194d9b03158fecddcd8cf02a7bc63620df17b8..3dcba13f5d2c617be6d24b1df9995f576ee23f8f 100644 (file)
--- a/docs/random/moving-plugins
+++ b/docs/random/moving-plugins
@@ -124,6 +124,9 @@ CHECKLIST
     - message strings need to be marked for translation 
     - should be short, well-written, clear
     - in particular, should *not* contain debug info, strerror, errno, ...
+      No, really ! NO STRERROR, NO ERRNO.  If you are too lazy to provide
+      the user of your library with a nice experience, put your crap in
+      the debug string
 
 - Decision should be made if it should go into good (LGPL license,
   LGPL dependencies, no patent issues) or ugly

diff --git a/plugins/elements/gstfilesrc.c b/plugins/elements/gstfilesrc.c
index 9e192be169f6c916cccbc82d1e0dff0b548178fe..6ba26a49e3c52b67956e4d4055ccbd9ae9fe9ef4 100644 (file)
--- a/plugins/elements/gstfilesrc.c
+++ b/plugins/elements/gstfilesrc.c
@@ -975,8 +975,8 @@ open_failed:
         break;
       default:
         GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ,
-            (_("Could not open file \"%s\" for reading: %s."), src->filename,
-                strerror (errno)), GST_ERROR_SYSTEM);
+            (_("Could not open file \"%s\" for reading."), src->filename),
+            GST_ERROR_SYSTEM);
         break;
     }
     return FALSE;