crypto: stm32 - Drop if block with always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 31 Jul 2023 16:54:55 +0000 (18:54 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 11 Aug 2023 11:19:27 +0000 (19:19 +0800)
stm32_hash_remove() is only called after stm32_hash_probe() succeeded. In
this case platform_set_drvdata() was called with a non-NULL data patameter.

The check for hdev being non-NULL can be dropped because hdev is never NULL
(or something bad like memory corruption happened and then the check
doesn't help any more either).

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/stm32/stm32-hash.c

index 75d281e..b102430 100644 (file)
@@ -2114,13 +2114,9 @@ err_reset:
 
 static int stm32_hash_remove(struct platform_device *pdev)
 {
-       struct stm32_hash_dev *hdev;
+       struct stm32_hash_dev *hdev = platform_get_drvdata(pdev);
        int ret;
 
-       hdev = platform_get_drvdata(pdev);
-       if (!hdev)
-               return -ENODEV;
-
        ret = pm_runtime_get_sync(hdev->dev);
 
        stm32_hash_unregister_algs(hdev);