efi_loader: error handling in efi_set_variable_common().
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Tue, 5 May 2020 23:37:25 +0000 (01:37 +0200)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Thu, 7 May 2020 16:23:16 +0000 (18:23 +0200)
Fix unreachable code. Free memory on error.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
lib/efi_loader/efi_variable.c

index 58f8fae..33df52e 100644 (file)
@@ -981,7 +981,7 @@ static efi_status_t efi_set_variable_common(u16 *variable_name,
        if (append) {
                old_data = malloc(old_size);
                if (!old_data) {
-                       return EFI_OUT_OF_RESOURCES;
+                       ret = EFI_OUT_OF_RESOURCES;
                        goto err;
                }
                ret = EFI_CALL(efi_get_variable(variable_name, vendor,