Fix presubmit errors.

TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/570024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3796 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/arm/codegen-arm.cc b/src/arm/codegen-arm.cc
index 10c88e855ef9229dc65c33b28257a1001d49d70d..5d4298d64fecebfbe7e72dd80572c3b91c71ecb4 100644 (file)
--- a/src/arm/codegen-arm.cc
+++ b/src/arm/codegen-arm.cc
@@ -225,7 +225,7 @@ void CodeGenerator::Generate(CompilationInfo* info, Mode mode) {
           Variable* par = scope()->parameter(i);
           Slot* slot = par->slot();
           if (slot != NULL && slot->type() == Slot::CONTEXT) {
-            ASSERT(!scope()->is_global_scope());  // no parameters in global scope
+            ASSERT(!scope()->is_global_scope());  // No params in global scope.
             __ ldr(r1, frame_->ParameterAt(i));
             // Loads r2 with context; used below in RecordWrite.
             __ str(r1, SlotOperand(slot, r2));

diff --git a/src/arm/codegen-arm.h b/src/arm/codegen-arm.h
index 462af1ed2ccd3afa0f5e6fb63e8459bbaff8fd31..6eb7c964d36e7bedf7c24d59db348a796dfec7bf 100644 (file)
--- a/src/arm/codegen-arm.h
+++ b/src/arm/codegen-arm.h
@@ -208,7 +208,7 @@ class CodeGenerator: public AstVisitor {
 
  private:
   // Construction/Destruction
-  CodeGenerator(MacroAssembler* masm);
+  explicit CodeGenerator(MacroAssembler* masm);
 
   // Accessors
   inline bool is_eval();

diff --git a/src/fast-codegen.h b/src/fast-codegen.h
index 8fae81f8b966a50479260334fa8a89921bb97263..0776571a2134033dd6ba89df0a57cac5d8ac3d7c 100644 (file)
--- a/src/fast-codegen.h
+++ b/src/fast-codegen.h
@@ -42,7 +42,7 @@ class FastCodeGenSyntaxChecker: public AstVisitor {
       : info_(NULL), has_supported_syntax_(true) {
   }
 
- void Check(CompilationInfo* info);
+  void Check(CompilationInfo* info);
 
   CompilationInfo* info() { return info_; }
   bool has_supported_syntax() { return has_supported_syntax_; }
@@ -65,7 +65,7 @@ class FastCodeGenSyntaxChecker: public AstVisitor {
 
 class FastCodeGenerator: public AstVisitor {
  public:
-  FastCodeGenerator(MacroAssembler* masm) : masm_(masm), info_(NULL) {}
+  explicit FastCodeGenerator(MacroAssembler* masm) : masm_(masm), info_(NULL) {}
 
   static Handle<Code> MakeCode(CompilationInfo* info);
 

diff --git a/src/full-codegen.h b/src/full-codegen.h
index 384588b47b122afa932c7d9a2928181052894c11..96d0f3e7e6e6172a8cfae4b0aeef50a41c3e09cc 100644 (file)
--- a/src/full-codegen.h
+++ b/src/full-codegen.h
@@ -68,7 +68,7 @@ class FullCodeGenerator: public AstVisitor {
     SECONDARY
   };
 
-  FullCodeGenerator(MacroAssembler* masm)
+  explicit FullCodeGenerator(MacroAssembler* masm)
       : masm_(masm),
         info_(NULL),
         nesting_stack_(NULL),

diff --git a/src/ia32/codegen-ia32.h b/src/ia32/codegen-ia32.h
index ee009f4b684bda8d4146187d923db8b7059223c8..296afb9bf19ec26d2da4e546b1cb876ca256571d 100644 (file)
--- a/src/ia32/codegen-ia32.h
+++ b/src/ia32/codegen-ia32.h
@@ -348,7 +348,7 @@ class CodeGenerator: public AstVisitor {
 
  private:
   // Construction/Destruction
-  CodeGenerator(MacroAssembler* masm);
+  explicit CodeGenerator(MacroAssembler* masm);
 
   // Accessors
   inline bool is_eval();

diff --git a/src/version.cc b/src/version.cc
index aea1a3a311d61a4160a6adba03275f9111c9c632..a2008616254fe9fd2e6eb85f76c60ffeafbc1f85 100644 (file)
--- a/src/version.cc
+++ b/src/version.cc
@@ -34,7 +34,7 @@
 // cannot be changed without changing the SCons build script.
 #define MAJOR_VERSION     2
 #define MINOR_VERSION     1
-#define BUILD_NUMBER      1 
+#define BUILD_NUMBER      1
 #define PATCH_LEVEL       0
 #define CANDIDATE_VERSION true
 

diff --git a/src/x64/codegen-x64.h b/src/x64/codegen-x64.h
index 4bc3454ad265a2a5e010cc300240144dfd7cc520..8fbbe5a650652998f922d5f22695f0e4229e89b1 100644 (file)
--- a/src/x64/codegen-x64.h
+++ b/src/x64/codegen-x64.h
@@ -348,7 +348,7 @@ class CodeGenerator: public AstVisitor {
 
  private:
   // Construction/Destruction
-  CodeGenerator(MacroAssembler* masm);
+  explicit CodeGenerator(MacroAssembler* masm);
 
   // Accessors
   inline bool is_eval();