rtspsrc: Error out when failling to receive message response
authorThibault Saunier <tsaunier@igalia.com>
Tue, 26 May 2020 00:11:31 +0000 (20:11 -0400)
committerThibault Saunier <tsaunier@igalia.com>
Tue, 26 May 2020 00:13:06 +0000 (20:13 -0400)
And let it rety twice.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/717

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/601>

gst/rtsp/gstrtspsrc.c

index f97f0a9..a2d258f 100644 (file)
@@ -6476,6 +6476,10 @@ again:
         goto again;
     }
   }
+
+  if (res < 0)
+    goto receive_error;
+
   gst_rtsp_ext_list_after_send (src->extensions, request, response);
 
   return res;
@@ -6493,6 +6497,20 @@ send_error:
     g_free (str);
     return res;
   }
+
+receive_error:
+  {
+    gchar *str = gst_rtsp_strresult (res);
+
+    if (res != GST_RTSP_EINTR) {
+      GST_ELEMENT_ERROR (src, RESOURCE, READ, (NULL),
+          ("Could not receive message. (%s)", str));
+    } else {
+      GST_WARNING_OBJECT (src, "receive interrupted");
+    }
+    g_free (str);
+    return res;
+  }
 }
 
 /**